Split big sitemaps & generate proper index (closes #79, #106) #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
stefandoorn
commented
Aug 24, 2020
stefandoorn
commented
- Split big sitemaps based on a configurable limit (defaults to 50.000)
- Use the amount of files in generation of the URIs to these files (and use them in the index)
|
@loevgaard I started working on this. I'm not very happy yet with the implementation. For sure the command does too much, but that's a refactor for later. The sending around of the amount of paths to the index provider should be more elegant, but couldn't come up with a better implementation right now. |
stefandoorn
changed the title
|
any estimation when it will be merged? |
1 similar comment
|
any estimation when it will be merged? |
|
Ah, haven't looked into it anymore. Have you maybe been able to test it in a real project? Would be great to have some feedback on the implementation. |
LucaGallinari
added a commit
to webgriffe/sitemap-plugin
that referenced
this pull request
Sep 20, 2023
This was referenced Sep 20, 2023
LucaGallinari
added a commit
to webgriffe/sitemap-plugin
that referenced
this pull request
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.